[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a change in pull request #15: Feature/sling 7768: String Interpolation for ETC Map

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [sling-org-apache-sling-resourceresolver] cziegeler commented on a change in pull request #15: Feature/sling 7768: String Interpolation for ETC Map

GitBox
cziegeler commented on a change in pull request #15: Feature/sling 7768: String Interpolation for ETC Map
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/15#discussion_r370504085
 
 

 ##########
 File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/Interpolator.java
 ##########
 @@ -0,0 +1,154 @@
+/*
 
 Review comment:
   We can embed it, exactly because it is not exported - but there is no strict need for it, other than to avoid code duplication - and as mentioned we can do this later on

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services