[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #41: SLING-8875 - Created new Goal to create an FM Descriptor from its POM

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #41: SLING-8875 - Created new Goal to create an FM Descriptor from its POM

GitBox
cziegeler commented on a change in pull request #41: SLING-8875 - Created new Goal to create an FM Descriptor from its POM
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/41#discussion_r370948867
 
 

 ##########
 File path: src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
 ##########
 @@ -0,0 +1,244 @@
+/*
 
 Review comment:
   It would be good if the renaming of the class file from IncludeArtifact to IncludeArtifactMojo would be done in a follow up change. Otherwise it is not easy to see what actually changed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services