[VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Andreas Schaefer-5
Hi,

This is the initial release of the Sling Feature Model Converter Plugin that is the Maven frontend to the Content Package Converter module allowing a developer to convert its CP module into a Feature Model to be used later in a Feature Launch.

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12346146

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2175/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2175 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Andreas Schaefer
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Georg Henzler-5
+1 (checked signatures and build)

Georg

On 2019-12-21 01:17, Andreas Schaefer wrote:

> Hi,
>
> This is the initial release of the Sling Feature Model Converter
> Plugin that is the Maven frontend to the Content Package Converter
> module allowing a developer to convert its CP module into a Feature
> Model to be used later in a Feature Launch.
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12346146
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2175/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2175 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Andreas Schaefer
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Robert Munteanu-2
In reply to this post by Andreas Schaefer-5
Hi Andy,

On Fri, 2019-12-20 at 16:17 -0800, Andreas Schaefer wrote:
> This is the initial release of the Sling Feature Model Converter
> Plugin

(snip)

The build seems to consistently fail on Jenkins

  https://builds.apache.org/blue/organizations/jenkins/Sling%2Fsling-feature-converter-maven-plugin/detail/master/28/pipeline

Is this known/intended?

Thanks,
Robert

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Andreas Schaefer-5
Hi Robert

All the IT tests are failing because the ‘core’ artifact is not installed locally. The invoker goals are set to ‘clean install’ but for the core that seems not to be applied. When I test it locally the core artifact (both POM and the JAR file) are installed in the local maven repo.

This is the current path: https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/ <https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/> to the created target folder of the latest build failure.

The IT tests are failing because the Maven is not able to find the IT project’s core artifact and that is not available in a remote repo. It is working just fine for me locally. As far as I can tell this is not an issue at all with the plugin but rather with the Invoker / IT tests.

Does anyone have a problem with it locally?

Is there are way to check the layout of the local Maven repo of such a build?

Cheers - Andy

> On Jan 6, 2020, at 4:10 AM, Robert Munteanu <[hidden email]> wrote:
>
> Hi Andy,
>
> On Fri, 2019-12-20 at 16:17 -0800, Andreas Schaefer wrote:
>> This is the initial release of the Sling Feature Model Converter
>> Plugin
>
> (snip)
>
> The build seems to consistently fail on Jenkins
>
>  https://builds.apache.org/blue/organizations/jenkins/Sling%2Fsling-feature-converter-maven-plugin/detail/master/28/pipeline
>
> Is this known/intended?
>
> Thanks,
> Robert
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Robert Munteanu-2
Hi,

On Mon, 2020-01-06 at 09:13 -0800, Andreas Schaefer wrote:

> Hi Robert
>
> All the IT tests are failing because the ‘core’ artifact is not
> installed locally. The invoker goals are set to ‘clean install’ but
> for the core that seems not to be applied. When I test it locally the
> core artifact (both POM and the JAR file) are installed in the local
> maven repo.
>
> This is the current path:
> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> <
> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> > to the created target folder of the latest build failure.
>
> The IT tests are failing because the Maven is not able to find the IT
> project’s core artifact and that is not available in a remote repo.
> It is working just fine for me locally. As far as I can tell this is
> not an issue at all with the plugin but rather with the Invoker / IT
> tests.
>
> Does anyone have a problem with it locally?
>
> Is there are way to check the layout of the local Maven repo of such
> a build?


I can not try at the moment, but try moving away ~/.m2/repository and
running the build then. It should fail in the same manner.

Robert

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Andreas Schaefer-5
I copied away my ~/.m2/repository and rebuilt the Maven Plugin and had no issues whatsoever.

- Andy

> On Jan 6, 2020, at 12:49 PM, Robert Munteanu <[hidden email]> wrote:
>
> Hi,
>
> On Mon, 2020-01-06 at 09:13 -0800, Andreas Schaefer wrote:
>> Hi Robert
>>
>> All the IT tests are failing because the ‘core’ artifact is not
>> installed locally. The invoker goals are set to ‘clean install’ but
>> for the core that seems not to be applied. When I test it locally the
>> core artifact (both POM and the JAR file) are installed in the local
>> maven repo.
>>
>> This is the current path:
>> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
>> <
>> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
>>> to the created target folder of the latest build failure.
>>
>> The IT tests are failing because the Maven is not able to find the IT
>> project’s core artifact and that is not available in a remote repo.
>> It is working just fine for me locally. As far as I can tell this is
>> not an issue at all with the plugin but rather with the Invoker / IT
>> tests.
>>
>> Does anyone have a problem with it locally?
>>
>> Is there are way to check the layout of the local Maven repo of such
>> a build?
>
>
> I can not try at the moment, but try moving away ~/.m2/repository and
> running the build then. It should fail in the same manner.
>
> Robert
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Robert Munteanu-2
On Tue, 2020-01-07 at 07:43 -0800, Andreas Schaefer wrote:
> I copied away my ~/.m2/repository and rebuilt the Maven Plugin and
> had no issues whatsoever.

Hm, that is weird. A fresh build of master fails for me:

[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 7, Failed: 4, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[ERROR] The following builds failed:
[ERROR] *  package-with-single-bundle-no-parameters/ui.apps/pom.xml
[ERROR] *  package-with-single-bundle-target-mode/fm.launcher/pom.xml
[ERROR] *  package-with-single-bundle-target-mode/ui.apps/pom.xml
[ERROR] *  package-with-single-bundle-with-parameters/ui.apps/pom.xml
[INFO] -------------------------------------------------

A second build works though.

Robert

>
> - Andy
>
> > On Jan 6, 2020, at 12:49 PM, Robert Munteanu <[hidden email]>
> > wrote:
> >
> > Hi,
> >
> > On Mon, 2020-01-06 at 09:13 -0800, Andreas Schaefer wrote:
> > > Hi Robert
> > >
> > > All the IT tests are failing because the ‘core’ artifact is not
> > > installed locally. The invoker goals are set to ‘clean install’
> > > but
> > > for the core that seems not to be applied. When I test it locally
> > > the
> > > core artifact (both POM and the JAR file) are installed in the
> > > local
> > > maven repo.
> > >
> > > This is the current path:
> > > https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> > > <
> > > https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> > > > to the created target folder of the latest build failure.
> > >
> > > The IT tests are failing because the Maven is not able to find
> > > the IT
> > > project’s core artifact and that is not available in a remote
> > > repo.
> > > It is working just fine for me locally. As far as I can tell this
> > > is
> > > not an issue at all with the plugin but rather with the Invoker /
> > > IT
> > > tests.
> > >
> > > Does anyone have a problem with it locally?
> > >
> > > Is there are way to check the layout of the local Maven repo of
> > > such
> > > a build?
> >
> > I can not try at the moment, but try moving away ~/.m2/repository
> > and
> > running the build then. It should fail in the same manner.
> >
> > Robert
> >

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Andreas Schaefer-5
If a subsequent build works it would mean that in the 2nd build it would find the dependency on *.core but not in the first.

This is my env:

 mvn --version
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T12:00:29-07:00)
Maven home: /Java/maven3
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: “mac"

Execution Order of the IT tests:

[INFO] --- maven-invoker-plugin:3.1.0:integration-test (integration-test) @ sling-feature-converter-maven-plugin ---
[INFO] Running 1 setup job:
[INFO] Building: setup-tests/pom.xml
[INFO]           setup-tests/pom.xml .............................. SUCCESS (2.2 s)
[INFO] Setup done.
[INFO] Building: package-with-single-bundle-no-parameters/core/pom.xml
[INFO]           package-with-single-bundle-no-parameters/core/pom.xml SUCCESS (8.8 s)
[INFO] Building: package-with-single-bundle-no-parameters/pom.xml
[INFO] run post-build script verify.bsh
[INFO]           package-with-single-bundle-no-parameters/pom.xml . SUCCESS (10.3 s)
[INFO] Building: package-with-single-bundle-no-parameters/ui.apps/pom.xml
[INFO]           package-with-single-bundle-no-parameters/ui.apps/pom.xml SUCCESS (2.8 s)
[INFO] Building: package-with-single-bundle-target-mode/core/pom.xml
[INFO]           package-with-single-bundle-target-mode/core/pom.xml SUCCESS (3.9 s)
[INFO] Building: package-with-single-bundle-target-mode/pom.xml
[INFO] run post-build script verify.bsh
[INFO]           package-with-single-bundle-target-mode/pom.xml ... SUCCESS (6.6 s)
[INFO] Building: package-with-single-bundle-target-mode/fm.launcher/pom.xml
[INFO]           package-with-single-bundle-target-mode/fm.launcher/pom.xml SUCCESS (2.2 s)
[INFO] Building: package-with-single-bundle-target-mode/ui.apps/pom.xml
[INFO]           package-with-single-bundle-target-mode/ui.apps/pom.xml SUCCESS (2.8 s)
[INFO] Building: package-with-single-bundle-with-parameters/core/pom.xml
[INFO]           package-with-single-bundle-with-parameters/core/pom.xml SUCCESS (3.8 s)
[INFO] Building: package-with-single-bundle-with-parameters/pom.xml
[INFO] run post-build script verify.bsh
[INFO]           package-with-single-bundle-with-parameters/pom.xml SUCCESS (5.4 s)
[INFO] Building: package-with-single-bundle-with-parameters/ui.apps/pom.xml
[INFO]           package-with-single-bundle-with-parameters/ui.apps/pom.xml SUCCESS (3.0 s)

I also ran the build with my settings.xml file moved away and it did still work.

Then I upgraded to Maven 3.6.3 and it still does work. What is your Maven / Java version?

The only thing that always made me wonder is the fact that the ui.apps are built in the integration-test after the root pom.xml if built but that worked for me with all the plugins that have IT tests and did not give me grief.

- Andy

> On Jan 8, 2020, at 6:49 AM, Robert Munteanu <[hidden email]> wrote:
>
> On Tue, 2020-01-07 at 07:43 -0800, Andreas Schaefer wrote:
>> I copied away my ~/.m2/repository and rebuilt the Maven Plugin and
>> had no issues whatsoever.
>
> Hm, that is weird. A fresh build of master fails for me:
>
> [INFO] -------------------------------------------------
> [INFO] Build Summary:
> [INFO]   Passed: 7, Failed: 4, Errors: 0, Skipped: 0
> [INFO] -------------------------------------------------
> [ERROR] The following builds failed:
> [ERROR] *  package-with-single-bundle-no-parameters/ui.apps/pom.xml
> [ERROR] *  package-with-single-bundle-target-mode/fm.launcher/pom.xml
> [ERROR] *  package-with-single-bundle-target-mode/ui.apps/pom.xml
> [ERROR] *  package-with-single-bundle-with-parameters/ui.apps/pom.xml
> [INFO] -------------------------------------------------
>
> A second build works though.
>
> Robert
>
>>
>> - Andy
>>
>>> On Jan 6, 2020, at 12:49 PM, Robert Munteanu <[hidden email]>
>>> wrote:
>>>
>>> Hi,
>>>
>>> On Mon, 2020-01-06 at 09:13 -0800, Andreas Schaefer wrote:
>>>> Hi Robert
>>>>
>>>> All the IT tests are failing because the ‘core’ artifact is not
>>>> installed locally. The invoker goals are set to ‘clean install’
>>>> but
>>>> for the core that seems not to be applied. When I test it locally
>>>> the
>>>> core artifact (both POM and the JAR file) are installed in the
>>>> local
>>>> maven repo.
>>>>
>>>> This is the current path:
>>>> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
>>>> <
>>>> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
>>>>> to the created target folder of the latest build failure.
>>>>
>>>> The IT tests are failing because the Maven is not able to find
>>>> the IT
>>>> project’s core artifact and that is not available in a remote
>>>> repo.
>>>> It is working just fine for me locally. As far as I can tell this
>>>> is
>>>> not an issue at all with the plugin but rather with the Invoker /
>>>> IT
>>>> tests.
>>>>
>>>> Does anyone have a problem with it locally?
>>>>
>>>> Is there are way to check the layout of the local Maven repo of
>>>> such
>>>> a build?
>>>
>>> I can not try at the moment, but try moving away ~/.m2/repository
>>> and
>>> running the build then. It should fail in the same manner.
>>>
>>> Robert
>>>
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Robert Munteanu-2
On Wed, 2020-01-08 at 07:55 -0800, Andreas Schaefer wrote:

> If a subsequent build works it would mean that in the 2nd build it
> would find the dependency on *.core but not in the first.
>
> This is my env:
>
>  mvn --version
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-
> 04-04T12:00:29-07:00)
> Maven home: /Java/maven3
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family:
> “mac"


I have

$ mvn -v
Apache Maven 3.6.2 (SUSE 3.6.2-1.1)
Maven home: /usr/share/maven
Java version: 11.0.5, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-11-openjdk-11
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.3.12-2-default", arch: "amd64", family: "unix"

I would say it's a JVM issue, but Jenkins runs on Java 8. Maybe Linux
vs Mac? At any rate, I would be hesistant of releasing a module with a
broken build on Jenkins.

Thank,
Robert

>
> Execution Order of the IT tests:
>
> [INFO] --- maven-invoker-plugin:3.1.0:integration-test (integration-
> test) @ sling-feature-converter-maven-plugin ---
> [INFO] Running 1 setup job:
> [INFO] Building: setup-tests/pom.xml
> [INFO]           setup-tests/pom.xml ..............................
> SUCCESS (2.2 s)
> [INFO] Setup done.
> [INFO] Building: package-with-single-bundle-no-
> parameters/core/pom.xml
> [INFO]           package-with-single-bundle-no-
> parameters/core/pom.xml SUCCESS (8.8 s)
> [INFO] Building: package-with-single-bundle-no-parameters/pom.xml
> [INFO] run post-build script verify.bsh
> [INFO]           package-with-single-bundle-no-parameters/pom.xml .
> SUCCESS (10.3 s)
> [INFO] Building: package-with-single-bundle-no-
> parameters/ui.apps/pom.xml
> [INFO]           package-with-single-bundle-no-
> parameters/ui.apps/pom.xml SUCCESS (2.8 s)
> [INFO] Building: package-with-single-bundle-target-mode/core/pom.xml
> [INFO]           package-with-single-bundle-target-mode/core/pom.xml
> SUCCESS (3.9 s)
> [INFO] Building: package-with-single-bundle-target-mode/pom.xml
> [INFO] run post-build script verify.bsh
> [INFO]           package-with-single-bundle-target-mode/pom.xml ...
> SUCCESS (6.6 s)
> [INFO] Building: package-with-single-bundle-target-
> mode/fm.launcher/pom.xml
> [INFO]           package-with-single-bundle-target-
> mode/fm.launcher/pom.xml SUCCESS (2.2 s)
> [INFO] Building: package-with-single-bundle-target-
> mode/ui.apps/pom.xml
> [INFO]           package-with-single-bundle-target-
> mode/ui.apps/pom.xml SUCCESS (2.8 s)
> [INFO] Building: package-with-single-bundle-with-
> parameters/core/pom.xml
> [INFO]           package-with-single-bundle-with-
> parameters/core/pom.xml SUCCESS (3.8 s)
> [INFO] Building: package-with-single-bundle-with-parameters/pom.xml
> [INFO] run post-build script verify.bsh
> [INFO]           package-with-single-bundle-with-parameters/pom.xml
> SUCCESS (5.4 s)
> [INFO] Building: package-with-single-bundle-with-
> parameters/ui.apps/pom.xml
> [INFO]           package-with-single-bundle-with-
> parameters/ui.apps/pom.xml SUCCESS (3.0 s)
>
> I also ran the build with my settings.xml file moved away and it did
> still work.
>
> Then I upgraded to Maven 3.6.3 and it still does work. What is your
> Maven / Java version?
>
> The only thing that always made me wonder is the fact that the
> ui.apps are built in the integration-test after the root pom.xml if
> built but that worked for me with all the plugins that have IT tests
> and did not give me grief.
>
> - Andy
>
> > On Jan 8, 2020, at 6:49 AM, Robert Munteanu <[hidden email]>
> > wrote:
> >
> > On Tue, 2020-01-07 at 07:43 -0800, Andreas Schaefer wrote:
> > > I copied away my ~/.m2/repository and rebuilt the Maven Plugin
> > > and
> > > had no issues whatsoever.
> >
> > Hm, that is weird. A fresh build of master fails for me:
> >
> > [INFO] -------------------------------------------------
> > [INFO] Build Summary:
> > [INFO]   Passed: 7, Failed: 4, Errors: 0, Skipped: 0
> > [INFO] -------------------------------------------------
> > [ERROR] The following builds failed:
> > [ERROR] *  package-with-single-bundle-no-parameters/ui.apps/pom.xml
> > [ERROR] *  package-with-single-bundle-target-
> > mode/fm.launcher/pom.xml
> > [ERROR] *  package-with-single-bundle-target-mode/ui.apps/pom.xml
> > [ERROR] *  package-with-single-bundle-with-
> > parameters/ui.apps/pom.xml
> > [INFO] -------------------------------------------------
> >
> > A second build works though.
> >
> > Robert
> >
> > > - Andy
> > >
> > > > On Jan 6, 2020, at 12:49 PM, Robert Munteanu <
> > > > [hidden email]>
> > > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Mon, 2020-01-06 at 09:13 -0800, Andreas Schaefer wrote:
> > > > > Hi Robert
> > > > >
> > > > > All the IT tests are failing because the ‘core’ artifact is
> > > > > not
> > > > > installed locally. The invoker goals are set to ‘clean
> > > > > install’
> > > > > but
> > > > > for the core that seems not to be applied. When I test it
> > > > > locally
> > > > > the
> > > > > core artifact (both POM and the JAR file) are installed in
> > > > > the
> > > > > local
> > > > > maven repo.
> > > > >
> > > > > This is the current path:
> > > > > https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> > > > > <
> > > > > https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> > > > > > to the created target folder of the latest build failure.
> > > > >
> > > > > The IT tests are failing because the Maven is not able to
> > > > > find
> > > > > the IT
> > > > > project’s core artifact and that is not available in a remote
> > > > > repo.
> > > > > It is working just fine for me locally. As far as I can tell
> > > > > this
> > > > > is
> > > > > not an issue at all with the plugin but rather with the
> > > > > Invoker /
> > > > > IT
> > > > > tests.
> > > > >
> > > > > Does anyone have a problem with it locally?
> > > > >
> > > > > Is there are way to check the layout of the local Maven repo
> > > > > of
> > > > > such
> > > > > a build?
> > > >
> > > > I can not try at the moment, but try moving away
> > > > ~/.m2/repository
> > > > and
> > > > running the build then. It should fail in the same manner.
> > > >
> > > > Robert
> > > >

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Sling Feature Model Converter Plugin 1.0.2

Andreas Schaefer-5
Hi Robert

I will check out the build with Java 11 and then try to run it under Ubuntu in a VM.

I will pull the plug on the release as I agree that a build must work but I was not aware that the build failed until you pointed it out.

Keep you posted - Andy

> On Jan 9, 2020, at 2:04 AM, Robert Munteanu <[hidden email]> wrote:
>
> On Wed, 2020-01-08 at 07:55 -0800, Andreas Schaefer wrote:
>> If a subsequent build works it would mean that in the 2nd build it
>> would find the dependency on *.core but not in the first.
>>
>> This is my env:
>>
>> mvn --version
>> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-
>> 04-04T12:00:29-07:00)
>> Maven home: /Java/maven3
>> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
>> /Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/jre
>> Default locale: en_US, platform encoding: UTF-8
>> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family:
>> “mac"
>
>
> I have
>
> $ mvn -v
> Apache Maven 3.6.2 (SUSE 3.6.2-1.1)
> Maven home: /usr/share/maven
> Java version: 11.0.5, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-11-openjdk-11
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.3.12-2-default", arch: "amd64", family: "unix"
>
> I would say it's a JVM issue, but Jenkins runs on Java 8. Maybe Linux
> vs Mac? At any rate, I would be hesistant of releasing a module with a
> broken build on Jenkins.
>
> Thank,
> Robert
>>
>> Execution Order of the IT tests:
>>
>> [INFO] --- maven-invoker-plugin:3.1.0:integration-test (integration-
>> test) @ sling-feature-converter-maven-plugin ---
>> [INFO] Running 1 setup job:
>> [INFO] Building: setup-tests/pom.xml
>> [INFO]           setup-tests/pom.xml ..............................
>> SUCCESS (2.2 s)
>> [INFO] Setup done.
>> [INFO] Building: package-with-single-bundle-no-
>> parameters/core/pom.xml
>> [INFO]           package-with-single-bundle-no-
>> parameters/core/pom.xml SUCCESS (8.8 s)
>> [INFO] Building: package-with-single-bundle-no-parameters/pom.xml
>> [INFO] run post-build script verify.bsh
>> [INFO]           package-with-single-bundle-no-parameters/pom.xml .
>> SUCCESS (10.3 s)
>> [INFO] Building: package-with-single-bundle-no-
>> parameters/ui.apps/pom.xml
>> [INFO]           package-with-single-bundle-no-
>> parameters/ui.apps/pom.xml SUCCESS (2.8 s)
>> [INFO] Building: package-with-single-bundle-target-mode/core/pom.xml
>> [INFO]           package-with-single-bundle-target-mode/core/pom.xml
>> SUCCESS (3.9 s)
>> [INFO] Building: package-with-single-bundle-target-mode/pom.xml
>> [INFO] run post-build script verify.bsh
>> [INFO]           package-with-single-bundle-target-mode/pom.xml ...
>> SUCCESS (6.6 s)
>> [INFO] Building: package-with-single-bundle-target-
>> mode/fm.launcher/pom.xml
>> [INFO]           package-with-single-bundle-target-
>> mode/fm.launcher/pom.xml SUCCESS (2.2 s)
>> [INFO] Building: package-with-single-bundle-target-
>> mode/ui.apps/pom.xml
>> [INFO]           package-with-single-bundle-target-
>> mode/ui.apps/pom.xml SUCCESS (2.8 s)
>> [INFO] Building: package-with-single-bundle-with-
>> parameters/core/pom.xml
>> [INFO]           package-with-single-bundle-with-
>> parameters/core/pom.xml SUCCESS (3.8 s)
>> [INFO] Building: package-with-single-bundle-with-parameters/pom.xml
>> [INFO] run post-build script verify.bsh
>> [INFO]           package-with-single-bundle-with-parameters/pom.xml
>> SUCCESS (5.4 s)
>> [INFO] Building: package-with-single-bundle-with-
>> parameters/ui.apps/pom.xml
>> [INFO]           package-with-single-bundle-with-
>> parameters/ui.apps/pom.xml SUCCESS (3.0 s)
>>
>> I also ran the build with my settings.xml file moved away and it did
>> still work.
>>
>> Then I upgraded to Maven 3.6.3 and it still does work. What is your
>> Maven / Java version?
>>
>> The only thing that always made me wonder is the fact that the
>> ui.apps are built in the integration-test after the root pom.xml if
>> built but that worked for me with all the plugins that have IT tests
>> and did not give me grief.
>>
>> - Andy
>>
>>> On Jan 8, 2020, at 6:49 AM, Robert Munteanu <[hidden email]>
>>> wrote:
>>>
>>> On Tue, 2020-01-07 at 07:43 -0800, Andreas Schaefer wrote:
>>>> I copied away my ~/.m2/repository and rebuilt the Maven Plugin
>>>> and
>>>> had no issues whatsoever.
>>>
>>> Hm, that is weird. A fresh build of master fails for me:
>>>
>>> [INFO] -------------------------------------------------
>>> [INFO] Build Summary:
>>> [INFO]   Passed: 7, Failed: 4, Errors: 0, Skipped: 0
>>> [INFO] -------------------------------------------------
>>> [ERROR] The following builds failed:
>>> [ERROR] *  package-with-single-bundle-no-parameters/ui.apps/pom.xml
>>> [ERROR] *  package-with-single-bundle-target-
>>> mode/fm.launcher/pom.xml
>>> [ERROR] *  package-with-single-bundle-target-mode/ui.apps/pom.xml
>>> [ERROR] *  package-with-single-bundle-with-
>>> parameters/ui.apps/pom.xml
>>> [INFO] -------------------------------------------------
>>>
>>> A second build works though.
>>>
>>> Robert
>>>
>>>> - Andy
>>>>
>>>>> On Jan 6, 2020, at 12:49 PM, Robert Munteanu <
>>>>> [hidden email]>
>>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> On Mon, 2020-01-06 at 09:13 -0800, Andreas Schaefer wrote:
>>>>>> Hi Robert
>>>>>>
>>>>>> All the IT tests are failing because the ‘core’ artifact is
>>>>>> not
>>>>>> installed locally. The invoker goals are set to ‘clean
>>>>>> install’
>>>>>> but
>>>>>> for the core that seems not to be applied. When I test it
>>>>>> locally
>>>>>> the
>>>>>> core artifact (both POM and the JAR file) are installed in
>>>>>> the
>>>>>> local
>>>>>> maven repo.
>>>>>>
>>>>>> This is the current path:
>>>>>> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
>>>>>> <
>>>>>> https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
>>>>>>> to the created target folder of the latest build failure.
>>>>>>
>>>>>> The IT tests are failing because the Maven is not able to
>>>>>> find
>>>>>> the IT
>>>>>> project’s core artifact and that is not available in a remote
>>>>>> repo.
>>>>>> It is working just fine for me locally. As far as I can tell
>>>>>> this
>>>>>> is
>>>>>> not an issue at all with the plugin but rather with the
>>>>>> Invoker /
>>>>>> IT
>>>>>> tests.
>>>>>>
>>>>>> Does anyone have a problem with it locally?
>>>>>>
>>>>>> Is there are way to check the layout of the local Maven repo
>>>>>> of
>>>>>> such
>>>>>> a build?
>>>>>
>>>>> I can not try at the moment, but try moving away
>>>>> ~/.m2/repository
>>>>> and
>>>>> running the build then. It should fail in the same manner.
>>>>>
>>>>> Robert
>>>>>
>

Reply | Threaded
Open this post in threaded view
|

[VOTE][CANCELLED] Release Apache Sling Feature Model Converter Plugin 1.0.2

Robert Munteanu-2
Hi Andy,

As you reported on another email thread, the tests are now fixed, which
is great news :-)

I have updated the email subject to make sure that the cancellation is
visible, please check the steps from [1] to make sure you followed all
of them.

Thanks!

Robert

[1]: https://sling.apache.org/documentation/development/release-management.html#canceling-the-release

On Thu, 2020-01-09 at 08:29 -0800, Andreas Schaefer wrote:

> Hi Robert
>
> I will check out the build with Java 11 and then try to run it under
> Ubuntu in a VM.
>
> I will pull the plug on the release as I agree that a build must work
> but I was not aware that the build failed until you pointed it out.
>
> Keep you posted - Andy
>
> > On Jan 9, 2020, at 2:04 AM, Robert Munteanu <[hidden email]>
> > wrote:
> >
> > On Wed, 2020-01-08 at 07:55 -0800, Andreas Schaefer wrote:
> > > If a subsequent build works it would mean that in the 2nd build
> > > it
> > > would find the dependency on *.core but not in the first.
> > >
> > > This is my env:
> > >
> > > mvn --version
> > > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> > > 2019-
> > > 04-04T12:00:29-07:00)
> > > Maven home: /Java/maven3
> > > Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> > > /Library/Java/JavaVirtualMachines/jdk1.8.0_201.jdk/Contents/Home/
> > > jre
> > > Default locale: en_US, platform encoding: UTF-8
> > > OS name: "mac os x", version: "10.14.6", arch: "x86_64", family:
> > > “mac"
> >
> > I have
> >
> > $ mvn -v
> > Apache Maven 3.6.2 (SUSE 3.6.2-1.1)
> > Maven home: /usr/share/maven
> > Java version: 11.0.5, vendor: Oracle Corporation, runtime:
> > /usr/lib64/jvm/java-11-openjdk-11
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "linux", version: "5.3.12-2-default", arch: "amd64",
> > family: "unix"
> >
> > I would say it's a JVM issue, but Jenkins runs on Java 8. Maybe
> > Linux
> > vs Mac? At any rate, I would be hesistant of releasing a module
> > with a
> > broken build on Jenkins.
> >
> > Thank,
> > Robert
> > > Execution Order of the IT tests:
> > >
> > > [INFO] --- maven-invoker-plugin:3.1.0:integration-test
> > > (integration-
> > > test) @ sling-feature-converter-maven-plugin ---
> > > [INFO] Running 1 setup job:
> > > [INFO] Building: setup-tests/pom.xml
> > > [INFO]           setup-tests/pom.xml
> > > ..............................
> > > SUCCESS (2.2 s)
> > > [INFO] Setup done.
> > > [INFO] Building: package-with-single-bundle-no-
> > > parameters/core/pom.xml
> > > [INFO]           package-with-single-bundle-no-
> > > parameters/core/pom.xml SUCCESS (8.8 s)
> > > [INFO] Building: package-with-single-bundle-no-parameters/pom.xml
> > > [INFO] run post-build script verify.bsh
> > > [INFO]           package-with-single-bundle-no-parameters/pom.xml
> > > .
> > > SUCCESS (10.3 s)
> > > [INFO] Building: package-with-single-bundle-no-
> > > parameters/ui.apps/pom.xml
> > > [INFO]           package-with-single-bundle-no-
> > > parameters/ui.apps/pom.xml SUCCESS (2.8 s)
> > > [INFO] Building: package-with-single-bundle-target-
> > > mode/core/pom.xml
> > > [INFO]           package-with-single-bundle-target-
> > > mode/core/pom.xml
> > > SUCCESS (3.9 s)
> > > [INFO] Building: package-with-single-bundle-target-mode/pom.xml
> > > [INFO] run post-build script verify.bsh
> > > [INFO]           package-with-single-bundle-target-mode/pom.xml
> > > ...
> > > SUCCESS (6.6 s)
> > > [INFO] Building: package-with-single-bundle-target-
> > > mode/fm.launcher/pom.xml
> > > [INFO]           package-with-single-bundle-target-
> > > mode/fm.launcher/pom.xml SUCCESS (2.2 s)
> > > [INFO] Building: package-with-single-bundle-target-
> > > mode/ui.apps/pom.xml
> > > [INFO]           package-with-single-bundle-target-
> > > mode/ui.apps/pom.xml SUCCESS (2.8 s)
> > > [INFO] Building: package-with-single-bundle-with-
> > > parameters/core/pom.xml
> > > [INFO]           package-with-single-bundle-with-
> > > parameters/core/pom.xml SUCCESS (3.8 s)
> > > [INFO] Building: package-with-single-bundle-with-
> > > parameters/pom.xml
> > > [INFO] run post-build script verify.bsh
> > > [INFO]           package-with-single-bundle-with-
> > > parameters/pom.xml
> > > SUCCESS (5.4 s)
> > > [INFO] Building: package-with-single-bundle-with-
> > > parameters/ui.apps/pom.xml
> > > [INFO]           package-with-single-bundle-with-
> > > parameters/ui.apps/pom.xml SUCCESS (3.0 s)
> > >
> > > I also ran the build with my settings.xml file moved away and it
> > > did
> > > still work.
> > >
> > > Then I upgraded to Maven 3.6.3 and it still does work. What is
> > > your
> > > Maven / Java version?
> > >
> > > The only thing that always made me wonder is the fact that the
> > > ui.apps are built in the integration-test after the root pom.xml
> > > if
> > > built but that worked for me with all the plugins that have IT
> > > tests
> > > and did not give me grief.
> > >
> > > - Andy
> > >
> > > > On Jan 8, 2020, at 6:49 AM, Robert Munteanu <[hidden email]
> > > > >
> > > > wrote:
> > > >
> > > > On Tue, 2020-01-07 at 07:43 -0800, Andreas Schaefer wrote:
> > > > > I copied away my ~/.m2/repository and rebuilt the Maven
> > > > > Plugin
> > > > > and
> > > > > had no issues whatsoever.
> > > >
> > > > Hm, that is weird. A fresh build of master fails for me:
> > > >
> > > > [INFO] -------------------------------------------------
> > > > [INFO] Build Summary:
> > > > [INFO]   Passed: 7, Failed: 4, Errors: 0, Skipped: 0
> > > > [INFO] -------------------------------------------------
> > > > [ERROR] The following builds failed:
> > > > [ERROR] *  package-with-single-bundle-no-
> > > > parameters/ui.apps/pom.xml
> > > > [ERROR] *  package-with-single-bundle-target-
> > > > mode/fm.launcher/pom.xml
> > > > [ERROR] *  package-with-single-bundle-target-
> > > > mode/ui.apps/pom.xml
> > > > [ERROR] *  package-with-single-bundle-with-
> > > > parameters/ui.apps/pom.xml
> > > > [INFO] -------------------------------------------------
> > > >
> > > > A second build works though.
> > > >
> > > > Robert
> > > >
> > > > > - Andy
> > > > >
> > > > > > On Jan 6, 2020, at 12:49 PM, Robert Munteanu <
> > > > > > [hidden email]>
> > > > > > wrote:
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > On Mon, 2020-01-06 at 09:13 -0800, Andreas Schaefer wrote:
> > > > > > > Hi Robert
> > > > > > >
> > > > > > > All the IT tests are failing because the ‘core’ artifact
> > > > > > > is
> > > > > > > not
> > > > > > > installed locally. The invoker goals are set to ‘clean
> > > > > > > install’
> > > > > > > but
> > > > > > > for the core that seems not to be applied. When I test it
> > > > > > > locally
> > > > > > > the
> > > > > > > core artifact (both POM and the JAR file) are installed
> > > > > > > in
> > > > > > > the
> > > > > > > local
> > > > > > > maven repo.
> > > > > > >
> > > > > > > This is the current path:
> > > > > > > https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> > > > > > > <
> > > > > > > https://builds.apache.org/job/Sling/job/sling-feature-converter-maven-plugin/job/master/32/execution/node/3/ws/target/it/
> > > > > > > > to the created target folder of the latest build
> > > > > > > > failure.
> > > > > > >
> > > > > > > The IT tests are failing because the Maven is not able to
> > > > > > > find
> > > > > > > the IT
> > > > > > > project’s core artifact and that is not available in a
> > > > > > > remote
> > > > > > > repo.
> > > > > > > It is working just fine for me locally. As far as I can
> > > > > > > tell
> > > > > > > this
> > > > > > > is
> > > > > > > not an issue at all with the plugin but rather with the
> > > > > > > Invoker /
> > > > > > > IT
> > > > > > > tests.
> > > > > > >
> > > > > > > Does anyone have a problem with it locally?
> > > > > > >
> > > > > > > Is there are way to check the layout of the local Maven
> > > > > > > repo
> > > > > > > of
> > > > > > > such
> > > > > > > a build?
> > > > > >
> > > > > > I can not try at the moment, but try moving away
> > > > > > ~/.m2/repository
> > > > > > and
> > > > > > running the build then. It should fail in the same manner.
> > > > > >
> > > > > > Robert
> > > > > >