[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
Report Content as Inappropriate

[jira] [Commented] (SLING-7043) Exporting com.codahale.metrics.MetricRegistry is breaking the abstraction

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SLING-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123220#comment-16123220 ]

Chetan Mehrotra commented on SLING-7043:

Export of MetricRegistry is required for other reporters to work (which are codehale specific) like those from [~ianeboston] at [1]. Normal Sling code in general should not require the access to reported values and should mostly be doing report

[1] https://github.com/ieb/statsd-reporter-osgi

> Exporting  com.codahale.metrics.MetricRegistry is breaking the abstraction
> --------------------------------------------------------------------------
>                 Key: SLING-7043
>                 URL: https://issues.apache.org/jira/browse/SLING-7043
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Commons Metrics 1.0.0
>            Reporter: Carsten Ziegeler
>            Priority: Blocker
>             Fix For: commons metrics 1.2.4
> commons metrics provides a nice abstraction over  com.codahale.metrics - however it is exporting  com.codahale.metrics.MetricRegistry which seems to be the only way to get at registered metrics objects. Which in turn is completely breaking the purpose of this bundle.
> So we should
> a) drop exporting that service and avoid leaking internal implementation details
> b) create our own version of the registry service

This message was sent by Atlassian JIRA