[jira] [Commented] (SLING-7256) Sling Models injector for CAConfig

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SLING-7256) Sling Models injector for CAConfig

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SLING-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746194#comment-16746194 ]

Niek Raaijmakers commented on SLING-7256:
-----------------------------------------

Hey Stefan, 

I prefer @Via because it utilizes existing injectors, therefore minimizing new code, and it also allows other injectors to hook into the caconfig resource.

I tested it with my code and it works perfectly fine with @Via and @ValueMapValue . 

Also, you can put the config name in the @Via value. So sounds to me this annotation is made for this use case.

 

However I don't think the difference is that huge to debate about :) rather see 1 of the 2 released sooner then later. 

> Sling Models injector for CAConfig
> ----------------------------------
>
>                 Key: SLING-7256
>                 URL: https://issues.apache.org/jira/browse/SLING-7256
>             Project: Sling
>          Issue Type: New Feature
>    Affects Versions: Sling Models Impl 1.4.4
>            Reporter: Henry Kuijpers
>            Assignee: Stefan Seifert
>            Priority: Major
>
> It would be great to have a Sling Models injector for CAConfig.
> An example could be:
> {code}
> @Component
> public class ContextAwareConfigurationInjector implements Injector {
>     public String getName() {
>         return "ca-config";
>     }
>     public Object getValue(Object adaptable, String name, Type declaredType, AnnotatedElement element,
>                            DisposalCallbackRegistry callbackRegistry) {
>         if (isConfigurationObject(declaredType)) {
>             final Resource resource;
>             if (adaptable instanceof Resource) {
>                 resource = (Resource) adaptable;
>             } else if (adaptable instanceof SlingHttpServletRequest) {
>                 // TODO: Is this always the correct resource? (Most often we want the one in /content)
>                 // So we do not want /conf/... for example
>                 final SlingHttpServletRequest request = (SlingHttpServletRequest)adaptable;
>                 final ResourceResolver resourceResolver = request.getResourceResolver();
>                 resource = resourceResolver.resolve(request, request.getRequestURI());
>             } else {
>                 throw new IllegalArgumentException("Either a resource or the request should be used");
>             }
>             final ConfigurationBuilder builder = resource.adaptTo(ConfigurationBuilder.class);
>             if (builder != null) {
>                 return builder.as((Class<?>) declaredType);
>             }
>         }
>         return null;
>     }
>     private static boolean isConfigurationObject(Type type) {
>         if (!(type instanceof Class<?>)) {
>             return false;
>         }
>         Class<?> clazz = (Class<?>) type;
>         return clazz.isAnnotation() && clazz.isAnnotationPresent(Configuration.class);
>     }
> }
> {code}
> + annotation:
> {code}
> @Target({ ElementType.FIELD, ElementType.METHOD, ElementType.PARAMETER })
> @Retention(RetentionPolicy.RUNTIME)
> @InjectAnnotation
> @Source("ca-config")
> @Qualifier
> public @interface CaConfig {
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)