[jira] [Commented] (SLING-8541) slingfeature-maven-plugin should allow for generated feature model files

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SLING-8541) slingfeature-maven-plugin should allow for generated feature model files

Oliver Lietz (Jira)

    [ https://issues.apache.org/jira/browse/SLING-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905629#comment-16905629 ]

Andreas Schaefer commented on SLING-8541:
-----------------------------------------

I tested your branch and it does not take any generated FM into account. My project starts with no FM files and when I run it for the first time the plugin will fail when the Aggregate Mojo is called even though between the start of the build and the invocation of the Aggregate Mojo there were FMs created.

Have a look at this project: [https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group]

Running it according to the Readme file will show you the issue on the first call. Subsequent builds work because then FMs are in the target/fm folder.

If you want we can use a generated fm folder as suggested even though this will bloat the code even more.

> slingfeature-maven-plugin should allow for generated feature model files
> ------------------------------------------------------------------------
>
>                 Key: SLING-8541
>                 URL: https://issues.apache.org/jira/browse/SLING-8541
>             Project: Sling
>          Issue Type: New Feature
>          Components: Feature Model
>    Affects Versions: slingfeature-maven-plugin 1.0.4
>            Reporter: Andreas Schaefer
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: slingfeature-maven-plugin 1.0.8
>
>
> The Sling Feature Maven Plugin is checking that the feature model folder is containing feature model files when the plugin is started.
> This fails when the FM are generated prior to the execution of the Sling Feature Maven Plugin. This check should be either made optional or moved prior to the actual execution of the Plugin's goal.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)