[jira] [Commented] (SLING-8625) Update oak version to 1.16.0, jackrabbit version to 2.18.2

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (SLING-8625) Update oak version to 1.16.0, jackrabbit version to 2.18.2

Oliver Lietz (Jira)

    [ https://issues.apache.org/jira/browse/SLING-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903259#comment-16903259 ]

angela commented on SLING-8625:

proposed patch attached.
one thing i noticed when building the module: due to OAK-8339, the jackrabbit-api is now present both in oak and in jackrabbit, which might be the reason for the following WARNing:

[WARNING] jackrabbit-api-2.18.2.jar, oak-jackrabbit-api-1.16.0.jar define 68 overlapping classes:
[WARNING]   - org.apache.jackrabbit.api.JackrabbitRepositoryFactory
[WARNING]   - org.apache.jackrabbit.api.security.authentication.token.TokenCredentials
[WARNING]   - org.apache.jackrabbit.api.security.JackrabbitAccessControlEntry
[WARNING]   - org.apache.jackrabbit.api.security.user.Impersonation
[WARNING]   - org.apache.jackrabbit.api.security.user.Group
[WARNING]   - org.apache.jackrabbit.api.security.user.Query
[WARNING]   - org.apache.jackrabbit.api.security.principal.ItemBasedPrincipal
[WARNING]   - org.apache.jackrabbit.api.security.authorization.PrincipalAccessControlList
[WARNING]   - org.apache.jackrabbit.api.security.principal.JackrabbitPrincipal
[WARNING]   - org.apache.jackrabbit.api.package-info
[WARNING]   - 58 more...
[WARNING] maven-shade-plugin has detected that some class files are
[WARNING] present in two or more JARs. When this happens, only one
[WARNING] single version of the class is copied to the uber jar.
[WARNING] Usually this is not harmful and you can skip these warnings,
[WARNING] otherwise try to manually exclude artifacts based on
[WARNING] mvn dependency:tree -Ddetail=true and the above output.
[WARNING] See http://maven.apache.org/plugins/maven-shade-plugin/

i don't know if that's something to worry about, but i suspect this may cause issues along the line. i quickly tried replacing _jackrabbit-api_ by _oak-jackrabbit-api_ (and referencing the oak-version) but that didn't help (maybe the other jackrabbit dependency _jackrabbit-jcr-commons_ also depends on jackrabbit-api and currently doesn't refer to the oak copy... but i didn't investigate any further). so, just stating it here for the sake of completeness and to raise awareness for  OAK-8339 with the sling community.

cc: [~[hidden email]]

> Update oak version to 1.16.0, jackrabbit version to 2.18.2
> ----------------------------------------------------------
>                 Key: SLING-8625
>                 URL: https://issues.apache.org/jira/browse/SLING-8625
>             Project: Sling
>          Issue Type: Task
>          Components: Testing
>            Reporter: angela
>            Priority: Major
>         Attachments: SLING-8625.patch
> [~rombert], due to the embedding added in _org.apache.sling.testing.sling-mock-oak_ with SLING-4824, it is not sufficient to update the version of jackrabbit and oak in _sling-jcr-repoinit_ in order to complete SLING-8602. at least i didn't manage to get my test passed and debugging revealed that at some point it resolves to the wrong version of oak i.e. the embedded one.
> so, unfortunately, it seems that i need an new release of _org.apache.sling.testing.sling-mock-oak_. for testing purpose i am helping myself with a snapshot dependencies but obviously that's not a option for the final version.

This message was sent by Atlassian JIRA