[jira] [Commented] (SLING-8626) Content Package Converter is taking Group from Package Group instead of from Maven Group

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SLING-8626) Content Package Converter is taking Group from Package Group instead of from Maven Group

Oliver Lietz (Jira)

    [ https://issues.apache.org/jira/browse/SLING-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905502#comment-16905502 ]

Andreas Schaefer commented on SLING-8626:
-----------------------------------------

The problem is that the Feature Model depends on Maven to find the artifacts and so if the package group does not match up with the maven group then we are running into problems with the launcher because it needs the POM file of the package which is now not in the same location. Actually the caller of the convert() method does not know where the converted package was copied to.

To showcase the issue I created a little test project: [https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group]

The test 'mvn package' must be run twice to see the issue (see the Readme.md file) but then you see this issue:

[ERROR] Failed to execute goal on project org.apache.sling.cpconverter.issue: Could not resolve dependencies for project org.apache.sling:org.apache.sling.cpconverter.issue:slingosgifeature:1.0.0-SNAPSHOT: Could not find artifact test-group:ui.apps:zip:cp2fm-converted:1.0.0-SNAPSHOT in apache.snapshots ([https://repository.apache.org/snapshots)]

If you run into issue with the test project let me know.

> Content Package Converter is taking Group from Package Group instead of from Maven Group
> ----------------------------------------------------------------------------------------
>
>                 Key: SLING-8626
>                 URL: https://issues.apache.org/jira/browse/SLING-8626
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>         Environment: Sling 11, Java 8
>            Reporter: Andreas Schaefer
>            Priority: Major
>
> There are two issues with the Content Package to Feature Model Converter with respect to groups:
>  # If a group is set in the Content Package then this group will be used in the Feature Id as well as for the folder where it is created
>  # If anything changes in the Content Package Vault properties then this will not be reflected in the conversion on a Mac (10.14, Mojave). This is because the deflated file remains the same and in my testing the file did not change even though the package did.
> The issue with the group is severe as the original POM file and the 'cp2fm-converted' file are not in the same location causing issues with the launcher at least.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)