[jira] Created: (SLING-317) Rename /classes to /var/classes

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SLING-317) Rename /classes to /var/classes

Andrei Shilov (Jira)
Rename /classes to /var/classes
-------------------------------

                 Key: SLING-317
                 URL: https://issues.apache.org/jira/browse/SLING-317
             Project: Sling
          Issue Type: Improvement
            Reporter: Bertrand Delacretaz
            Priority: Minor


Currently the JSP engine uses  /classes to store compiled classes, as discussed on list this will be moved to /var/classes. The idea is to use /var for transient stuff that is not usually "interesting" to developers

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SLING-317) Rename /classes to /var/classes

Andrei Shilov (Jira)

    [ https://issues.apache.org/jira/browse/SLING-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576905#action_12576905 ]

Felix Meschberger commented on SLING-317:
-----------------------------------------

After reconfiguring the JSP ScriptEngine, do not forget to change the default configuration of the repository class loader to also use /var/classes and of the maven-jspc-plugin to also compile into /var/classes (if this latter setup is not inherited from the jasper module)

> Rename /classes to /var/classes
> -------------------------------
>
>                 Key: SLING-317
>                 URL: https://issues.apache.org/jira/browse/SLING-317
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>
> Currently the JSP engine uses  /classes to store compiled classes, as discussed on list this will be moved to /var/classes. The idea is to use /var for transient stuff that is not usually "interesting" to developers

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SLING-317) Rename /classes to /var/classes

Andrei Shilov (Jira)
In reply to this post by Andrei Shilov (Jira)

     [ https://issues.apache.org/jira/browse/SLING-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz updated SLING-317:
--------------------------------------

    Attachment: SLING-317.patch

Here's a patch that changes to /var/classes in the scripting/jsp and jcr/classloader modules, but I'm not sure what needs to be changed in the maven-jspc-plugin module.

> Rename /classes to /var/classes
> -------------------------------
>
>                 Key: SLING-317
>                 URL: https://issues.apache.org/jira/browse/SLING-317
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-317.patch
>
>
> Currently the JSP engine uses  /classes to store compiled classes, as discussed on list this will be moved to /var/classes. The idea is to use /var for transient stuff that is not usually "interesting" to developers

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SLING-317) Rename /classes to /var/classes

Andrei Shilov (Jira)
In reply to this post by Andrei Shilov (Jira)

    [ https://issues.apache.org/jira/browse/SLING-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583698#action_12583698 ]

Felix Meschberger commented on SLING-317:
-----------------------------------------

This patch looks good to me can probably be applied.

The JspC plugin currently by default compiles into target/classes which gets into the root of the bundle. This is not suitable for the BundleResourceProvider for the moment. I had a prototype for this, which allowed for prefix mapping when providing bundle resources, such as

       /org/apache/jasper/sample=/var/classes/org/apache/jasper/sample

would provide anything under  /org/apache/jasper/sample in the bundle to resources under /var/classes/org/apache/jasper/sample.

Otherwise, we could just compile the JSP classes such that the appear below /var/classes in the bundle. But then we could not use normal bundle classloaders to load these JSPs any more. So the path mapping allong above lines probably is better.

WDYT ?

> Rename /classes to /var/classes
> -------------------------------
>
>                 Key: SLING-317
>                 URL: https://issues.apache.org/jira/browse/SLING-317
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-317.patch
>
>
> Currently the JSP engine uses  /classes to store compiled classes, as discussed on list this will be moved to /var/classes. The idea is to use /var for transient stuff that is not usually "interesting" to developers

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SLING-317) Rename /classes to /var/classes

Andrei Shilov (Jira)
In reply to this post by Andrei Shilov (Jira)

    [ https://issues.apache.org/jira/browse/SLING-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584447#action_12584447 ]

Bertrand Delacretaz commented on SLING-317:
-------------------------------------------

I agree that the path mapping is better - do I need to wait for this to be implemented before applying the attached patch?

IIUC, applying the patch without fixing the JspC plugin would make that plugin useless?

> Rename /classes to /var/classes
> -------------------------------
>
>                 Key: SLING-317
>                 URL: https://issues.apache.org/jira/browse/SLING-317
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-317.patch
>
>
> Currently the JSP engine uses  /classes to store compiled classes, as discussed on list this will be moved to /var/classes. The idea is to use /var for transient stuff that is not usually "interesting" to developers

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SLING-317) Rename /classes to /var/classes

Andrei Shilov (Jira)
In reply to this post by Andrei Shilov (Jira)

    [ https://issues.apache.org/jira/browse/SLING-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584448#action_12584448 ]

Felix Meschberger commented on SLING-317:
-----------------------------------------

Just go ahead with this patch. Currently the classes prepared by the JspC plugin cannot be used anyway, but this is not a JspC problem but a BundleResourceProvider problem not supporting this mapping.

What we might do in the JspC plugin is provide a functionality to automatically insert the path mapping for the JSP classes. But we should not block this issue because of the JspC problem. We can do this in another JIRA.

> Rename /classes to /var/classes
> -------------------------------
>
>                 Key: SLING-317
>                 URL: https://issues.apache.org/jira/browse/SLING-317
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-317.patch
>
>
> Currently the JSP engine uses  /classes to store compiled classes, as discussed on list this will be moved to /var/classes. The idea is to use /var for transient stuff that is not usually "interesting" to developers

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (SLING-317) Rename /classes to /var/classes

Andrei Shilov (Jira)
In reply to this post by Andrei Shilov (Jira)

     [ https://issues.apache.org/jira/browse/SLING-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz closed SLING-317.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0

Patch applied, SLING-350 created regarding maven-jspc-plugin changes

> Rename /classes to /var/classes
> -------------------------------
>
>                 Key: SLING-317
>                 URL: https://issues.apache.org/jira/browse/SLING-317
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: SLING-317.patch
>
>
> Currently the JSP engine uses  /classes to store compiled classes, as discussed on list this will be moved to /var/classes. The idea is to use /var for transient stuff that is not usually "interesting" to developers

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.