[jira] Created: (SLING-639) Bug in SimpleWebDAVServlet

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SLING-639) Bug in SimpleWebDAVServlet

Robert Munteanu (Jira)
Bug in SimpleWebDAVServlet
--------------------------

                 Key: SLING-639
                 URL: https://issues.apache.org/jira/browse/SLING-639
             Project: Sling
          Issue Type: Bug
          Components: JCR
    Affects Versions: JCR Webdav 2.0.2
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger


Reported by Marc Speck in [1]

When PathInfo is null or "/", a response is already created and it makes no
sense to call super.service() anymore:


Index: SimpleWebDavServlet.java
===================================================================
--- SimpleWebDavServlet.java    (revision 691120)
+++ SimpleWebDavServlet.java    (working copy)
@@ -85,9 +85,9 @@
                 uri += slingRepo.getDefaultWorkspace();
                 response.sendRedirect(uri);
             }
+        } else {
+            super.service(request, response);
         }
-
-        super.service(request, response);
     }

     // ---------- SCR integration
----------------------------------------------


Regards,
Marc


[1] http://markmail.org/message/z3tp43u54a7yqhqn

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SLING-639) Bug in SimpleWebDAVServlet

Robert Munteanu (Jira)

     [ https://issues.apache.org/jira/browse/SLING-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-639.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: JCR Webdav 2.0.4

Fixed as proposed in Rev. 691374.

Awating feedback  before closing.

> Bug in SimpleWebDAVServlet
> --------------------------
>
>                 Key: SLING-639
>                 URL: https://issues.apache.org/jira/browse/SLING-639
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR Webdav 2.0.2
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Webdav 2.0.4
>
>
> Reported by Marc Speck in [1]
> When PathInfo is null or "/", a response is already created and it makes no
> sense to call super.service() anymore:
> Index: SimpleWebDavServlet.java
> ===================================================================
> --- SimpleWebDavServlet.java    (revision 691120)
> +++ SimpleWebDavServlet.java    (working copy)
> @@ -85,9 +85,9 @@
>                  uri += slingRepo.getDefaultWorkspace();
>                  response.sendRedirect(uri);
>              }
> +        } else {
> +            super.service(request, response);
>          }
> -
> -        super.service(request, response);
>      }
>      // ---------- SCR integration
> ----------------------------------------------
> Regards,
> Marc
> [1] http://markmail.org/message/z3tp43u54a7yqhqn

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (SLING-639) Bug in SimpleWebDAVServlet

Robert Munteanu (Jira)
In reply to this post by Robert Munteanu (Jira)

     [ https://issues.apache.org/jira/browse/SLING-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed SLING-639.
-----------------------------------


Fix confirmed to be ok. Closing

> Bug in SimpleWebDAVServlet
> --------------------------
>
>                 Key: SLING-639
>                 URL: https://issues.apache.org/jira/browse/SLING-639
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR Webdav 2.0.2
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Webdav 2.0.4
>
>
> Reported by Marc Speck in [1]
> When PathInfo is null or "/", a response is already created and it makes no
> sense to call super.service() anymore:
> Index: SimpleWebDavServlet.java
> ===================================================================
> --- SimpleWebDavServlet.java    (revision 691120)
> +++ SimpleWebDavServlet.java    (working copy)
> @@ -85,9 +85,9 @@
>                  uri += slingRepo.getDefaultWorkspace();
>                  response.sendRedirect(uri);
>              }
> +        } else {
> +            super.service(request, response);
>          }
> -
> -        super.service(request, response);
>      }
>      // ---------- SCR integration
> ----------------------------------------------
> Regards,
> Marc
> [1] http://markmail.org/message/z3tp43u54a7yqhqn

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.