[jira] [Resolved] (SLING-2804) fixcrlf breaks build when skipping tests.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SLING-2804) fixcrlf breaks build when skipping tests.

Robert Munteanu (Jira)

     [ https://issues.apache.org/jira/browse/SLING-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-2804.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: Taglib Archetype 1.0.0

Solved by creating the dir if it doesn't exists (rev 1506420)

The more correct solution would be to run the ant task only if tests are enabled, but I think doing that is way too complicated and bloats the pom
               

> fixcrlf breaks build when skipping tests.
> ------------------------------------------
>
>                 Key: SLING-2804
>                 URL: https://issues.apache.org/jira/browse/SLING-2804
>             Project: Sling
>          Issue Type: Bug
>          Components: General
>    Affects Versions: Taglib Archetype 1.0.0
>         Environment: -Dmaven.test.skip=true
>            Reporter: Ian Boston
>            Assignee: Carsten Ziegeler
>             Fix For: Taglib Archetype 1.0.0
>
>
> INFO] Final Memory: 45M/161M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (fix-crlfs) on project sling-taglib-archetype: An Ant BuildException has occured: <fixcrlf> error: srcdir does not exist: '/Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/test-classes'
> [ERROR] around Ant part ...<fixcrlf srcdir="/Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/test-classes"/>... @ 4:96 in /Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/antrun/build-main.xml
> [ERROR] -> [Help 1]
> [ERROR]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Resolved] (SLING-2804) fixcrlf breaks build when skipping tests.

Felix Meschberger-3
Hi

Could that be solved by a profile which is enabled only if the "skipTests" property is not set ?

Regards
Felix

Am 24.07.2013 um 09:49 schrieb Carsten Ziegeler (JIRA):

>
>     [ https://issues.apache.org/jira/browse/SLING-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Carsten Ziegeler resolved SLING-2804.
> -------------------------------------
>
>       Resolution: Fixed
>    Fix Version/s: Taglib Archetype 1.0.0
>
> Solved by creating the dir if it doesn't exists (rev 1506420)
>
> The more correct solution would be to run the ant task only if tests are enabled, but I think doing that is way too complicated and bloats the pom
>
>> fixcrlf breaks build when skipping tests.
>> ------------------------------------------
>>
>>                Key: SLING-2804
>>                URL: https://issues.apache.org/jira/browse/SLING-2804
>>            Project: Sling
>>         Issue Type: Bug
>>         Components: General
>>   Affects Versions: Taglib Archetype 1.0.0
>>        Environment: -Dmaven.test.skip=true
>>           Reporter: Ian Boston
>>           Assignee: Carsten Ziegeler
>>            Fix For: Taglib Archetype 1.0.0
>>
>>
>> INFO] Final Memory: 45M/161M
>> [INFO] ------------------------------------------------------------------------
>> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (fix-crlfs) on project sling-taglib-archetype: An Ant BuildException has occured: <fixcrlf> error: srcdir does not exist: '/Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/test-classes'
>> [ERROR] around Ant part ...<fixcrlf srcdir="/Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/test-classes"/>... @ 4:96 in /Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/antrun/build-main.xml
>> [ERROR] -> [Help 1]
>> [ERROR]
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

Re: [jira] [Resolved] (SLING-2804) fixcrlf breaks build when skipping tests.

Carsten Ziegeler
Yes, but that's imho too complicated to setup - so I took the pragmatic
solution and just create the dir upfront - which doesn't hurt.


But if someone wants to do this the profile way, I'm fine :)

Carsten


2013/7/24 Felix Meschberger <[hidden email]>

> Hi
>
> Could that be solved by a profile which is enabled only if the "skipTests"
> property is not set ?
>
> Regards
> Felix
>
> Am 24.07.2013 um 09:49 schrieb Carsten Ziegeler (JIRA):
>
> >
> >     [
> https://issues.apache.org/jira/browse/SLING-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
> >
> > Carsten Ziegeler resolved SLING-2804.
> > -------------------------------------
> >
> >       Resolution: Fixed
> >    Fix Version/s: Taglib Archetype 1.0.0
> >
> > Solved by creating the dir if it doesn't exists (rev 1506420)
> >
> > The more correct solution would be to run the ant task only if tests are
> enabled, but I think doing that is way too complicated and bloats the pom
> >
> >> fixcrlf breaks build when skipping tests.
> >> ------------------------------------------
> >>
> >>                Key: SLING-2804
> >>                URL: https://issues.apache.org/jira/browse/SLING-2804
> >>            Project: Sling
> >>         Issue Type: Bug
> >>         Components: General
> >>   Affects Versions: Taglib Archetype 1.0.0
> >>        Environment: -Dmaven.test.skip=true
> >>           Reporter: Ian Boston
> >>           Assignee: Carsten Ziegeler
> >>            Fix For: Taglib Archetype 1.0.0
> >>
> >>
> >> INFO] Final Memory: 45M/161M
> >> [INFO]
> ------------------------------------------------------------------------
> >> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.7:run (fix-crlfs) on project
> sling-taglib-archetype: An Ant BuildException has occured: <fixcrlf> error:
> srcdir does not exist:
> '/Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/test-classes'
> >> [ERROR] around Ant part ...<fixcrlf
> srcdir="/Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/test-classes"/>...
> @ 4:96 in
> /Users/ieb/Apache/sling/trunk/maven/archetypes/taglib/target/antrun/build-main.xml
> >> [ERROR] -> [Help 1]
> >> [ERROR]
> >
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> administrators
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>


--
Carsten Ziegeler
[hidden email]