[jira] [Resolved] (SLING-8221) Feature model does not override from command line a property if set in pom.xml

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SLING-8221) Feature model does not override from command line a property if set in pom.xml

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SLING-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Bosschaert resolved SLING-8221.
-------------------------------------
    Resolution: Fixed

Implemented in [https://gitbox.apache.org/repos/asf?p=sling-slingstart-maven-plugin.git;a=commitdiff;h=31b80d6520aac09038a55700954461164f619215] and https://gitbox.apache.org/repos/asf?p=sling-slingfeature-maven-plugin.git;a=commitdiff;h=eb1ad3dc0381529552ce9fb7babbb1bf78577fa0

> Feature model does not override from command line a property if set in pom.xml
> ------------------------------------------------------------------------------
>
>                 Key: SLING-8221
>                 URL: https://issues.apache.org/jira/browse/SLING-8221
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>    Affects Versions: Slingstart Maven Plugin 1.8.2, slingfeature-maven-plugin 0.8.0
>            Reporter: Davide Giannella
>            Assignee: David Bosschaert
>            Priority: Major
>             Fix For: Slingstart Maven Plugin 1.8.4, slingfeature-maven-plugin 0.8.2
>
>
> If you set a property in the pom.xml in the format of
> {code:xml}
> <properties>
>   <oak.version>1.2.3</oak.version>
> </properties>
> {code}
> and you use it in a json file to specify a dependency
> {code}
>    ...
>     {
>       "id":"org.apache.jackrabbit:oak-core-spi:${oak.version}",
>       "start-level":"15"
>     },
>    ...
> {code}
> if you then try to override it from command line with something like
> {noformat}
> mvn clean verify -Doak.version=4.5.6
> {noformat}
> the generated jar will eventually have the version {{1.2.3}}
>  
> /cc [~bosschaert], [~kpauls]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)